<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Dear Andreas,</p>
<p>You are definitely right about the implementation, this is indeed
an oversight. The instruction should be continued instead of
returned, and the nb_lines should be updated accodingly.<br>
<br>
Many thanks for spotting it!</p>
<p>Best regards,<br>
Thibaut<br>
</p>
<div class="moz-cite-prefix">On 24/02/2021 18:01, Andreas Bolke
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:158f87d6-c5b7-e110-881f-6e28e058b6d7@gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
Dear Castor Developers,<br>
<br>
first of all, thanks for making Castor open source and maintaining
the code in the first place. It has already helped me<br>
to find Bugs in my own reconstruction when I was comparing my
results to the castor result.<br>
<br>
Well I guess I get right to the point then. <br>
I use very simple GATE data to make PET reconstructions and
compare them to my own reconstruction.<br>
If I understand multiray correctly, then I think in
iProjectorIncrementalSiddonMulti::ProjectWithoutTOF() the line
282:<br>
<br>
<i> if( alphaMax <= alphaMin ) return 0;</i><br>
<br>
will cause the function to return prematurely without having
iterated over all lines (I mean multiray lines, not
oProjectionLine objects).<br>
This can cause for example low sensitivity values on the edges (I
added a screenshot to the attachment). <br>
When for example you use 16 lines, but because of the<br>
random position of each line, line no. 2 might not hit a voxel,
the function will return and stop iterating over <br>
the remaining 14 lines.<br>
<br>
Or am I missing something? If this is the case, I apologize in
advance.<br>
<br>
<br>
Best regards,<br>
Andreas<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
Castor-users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Castor-users@lists.castor-project.org">Castor-users@lists.castor-project.org</a>
<a class="moz-txt-link-freetext" href="http://lists.castor-project.org/listinfo/castor-users">http://lists.castor-project.org/listinfo/castor-users</a>
To look for something in the mailing-list archives, use the search box at:
<a class="moz-txt-link-freetext" href="https://castor-project.org/mailing-list">https://castor-project.org/mailing-list</a></pre>
</blockquote>
<pre class="moz-signature" cols="72">--
Thibaut MERLIN -- PhD
Docteur en Imagerie Médicale au Laboratoire de Traitement de l'Information Medicale (LaTIM - INSERM UMR 1101)
Institut Brestois de recherche en Bio-Santé (IBRBS)
12 Avenue Foch, 29200 Brest, FRANCE
Tel: 06.75.12.24.90</pre>
</body>
</html>